[acassen/keepalived] 6d42cc: Don't save and restore current directory twice wit...

pqarmitage <[email protected]> Sat, 26 Nov 2016 04:50:29 -0800
Newsgroups	gmane.linux.keepalived.devel
Message-ID	<58398515747c6_12963fdb85017138119811@hookshot-fe1-cp1-prd.iad.github.net.mail>
  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 6d42cc83ba3db6d51c53054e0ec02e1d6b7a1f32
      https://github.com/acassen/keepalived/commit/6d42cc83ba3db6d51c53054e0ec02e1d6b7a1f32
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M doc/man/man5/keepalived.conf.5
    M lib/parser.c

  Log Message:
  -----------
  Don't save and restore current directory twice with config includes

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 2ebea8edfe53f2fd392dbc25df711e8c9e95348c
      https://github.com/acassen/keepalived/commit/2ebea8edfe53f2fd392dbc25df711e8c9e95348c
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M lib/parser.c

  Log Message:
  -----------
  Fix commit 6d42cc8

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 6f6143ceab0907091d0b924316bfc7f4c38b15a3
      https://github.com/acassen/keepalived/commit/6f6143ceab0907091d0b924316bfc7f4c38b15a3
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M lib/parser.c

  Log Message:
  -----------
  Don't recognise an executable file as a configuration file

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: ebd439802f9932807fb898f0a489a44f288a90f6
      https://github.com/acassen/keepalived/commit/ebd439802f9932807fb898f0a489a44f288a90f6
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M lib/parser.c

  Log Message:
  -----------
  Allow maximum path names for configuration files

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 137885a30a7d18c1c31e4292784c4ada898514cf
      https://github.com/acassen/keepalived/commit/137885a30a7d18c1c31e4292784c4ada898514cf
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-22 (Tue, 22 Nov 2016)

  Changed paths:
    M lib/parser.c

  Log Message:
  -----------
  Don't check for include file after reaching EOF

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 84df08b2be0657cb2746c605c8576901c7b4ad47
      https://github.com/acassen/keepalived/commit/84df08b2be0657cb2746c605c8576901c7b4ad47
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-23 (Wed, 23 Nov 2016)

  Changed paths:
    M keepalived/vrrp/vrrp.c

  Log Message:
  -----------
  Fix a segfault if terminating at startup do to interface not found

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: ed2709d460dc62bce63e462dfaf25406872587e1
      https://github.com/acassen/keepalived/commit/ed2709d460dc62bce63e462dfaf25406872587e1
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-24 (Thu, 24 Nov 2016)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Merge branch 'master' into fixes


  Commit: 3ed832aa9810df7593abec357cbd9febcc690638
      https://github.com/acassen/keepalived/commit/3ed832aa9810df7593abec357cbd9febcc690638
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-24 (Thu, 24 Nov 2016)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Don't execute a script if setuid or setgid fails

This was suggested in the comment of commit 849615d and is clearly
the right (secure) thing to do.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 88d945800af6387f46a1acbe3d15882df487b2cb
      https://github.com/acassen/keepalived/commit/88d945800af6387f46a1acbe3d15882df487b2cb
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-25 (Fri, 25 Nov 2016)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  If a script doesn't have a '/' in the name, search PATH for it

This also handles spaces in script specifications where they are
parameters.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 547a9b89f2ac4cf67b31e87bbbcf6e345ee64a7d
      https://github.com/acassen/keepalived/commit/547a9b89f2ac4cf67b31e87bbbcf6e345ee64a7d
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-25 (Fri, 25 Nov 2016)

  Changed paths:
    M keepalived/vrrp/vrrp.c

  Log Message:
  -----------
  Don't allow accept when strict mode set if not address owner

This commit changes keepalived from just issuing a warning to also
disable accept mode when strict mode is set.

Patch submitted by levin1.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 023258c0bdefe670e82ad5e33da9a3d7e97ac08f
      https://github.com/acassen/keepalived/commit/023258c0bdefe670e82ad5e33da9a3d7e97ac08f
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-26 (Sat, 26 Nov 2016)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  When checking script security check set uid/gid bits too

Although the setuid/gid bits are ignored for scripts, they are
not ignored for binary executables, and there is no point in having
the bits set for scripts. So we play safe, and simply check those
bits, and don't attempt to ascertain if it is a script or not.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 8e05c9a0d3715fd3c139ee00fac2e809ca3d7fc3
      https://github.com/acassen/keepalived/commit/8e05c9a0d3715fd3c139ee00fac2e809ca3d7fc3
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-26 (Sat, 26 Nov 2016)

  Changed paths:
    M keepalived/check/check_misc.c
    M keepalived/include/check_misc.h
    M keepalived/include/vrrp_track.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_print.c
    M lib/notify.c

  Log Message:
  -----------
  Disable scripts that aren't executable

system() on a non-executable script will fail, so we may as well
just not try executing such a script.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 0f41b606f901a7e6ef6ba5432a0e859485c1c0aa
      https://github.com/acassen/keepalived/commit/0f41b606f901a7e6ef6ba5432a0e859485c1c0aa
  Author: pqarmitage <[email protected]>
  Date:   2016-11-26 (Sat, 26 Nov 2016)

  Changed paths:
    M doc/man/man5/keepalived.conf.5
    M keepalived/check/check_misc.c
    M keepalived/include/check_misc.h
    M keepalived/include/vrrp_track.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_print.c
    M lib/notify.c
    M lib/parser.c

  Log Message:
  -----------
  Merge pull request #469 from pqarmitage/fixes

Various script security enhancements


Compare: https://github.com/acassen/keepalived/compare/849615d50812...0f41b606f901

------------------------------------------------------------------------------

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel