[acassen/keepalived] 3455c4: Exit if can't read configuration file

pqarmitage <[email protected]>
Newsgroups gmane.linux.keepalived.devel
Message-ID <583994e3bbda2_602f3f9a7f0bf14091091@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail>
  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 3455c4a978b678a21b0cdc86db7db13767f507e3
      https://github.com/acassen/keepalived/commit/3455c4a978b678a21b0cdc86db7db13767f507e3
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-26 (Sat, 26 Nov 2016)

  Changed paths:
    M lib/parser.c

  Log Message:
  -----------
  Exit if can't read configuration file

If we have no configuration, we have nothing to run, so exit.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 3b91ebe1234397a80522924ba3d943cc2d7253c5
      https://github.com/acassen/keepalived/commit/3b91ebe1234397a80522924ba3d943cc2d7253c5
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-26 (Sat, 26 Nov 2016)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/vrrp/vrrp_daemon.c

  Log Message:
  -----------
  Don't chdir("/") if not forking

In keepalived_main() there is a comment that the working directory
is / unless keepalived is run in non-forked mode, in which case it
remains the current working directory when keepalived was run.

Unfortunately start_vrrp_child() and start_check_child() were
executing chdir("/") regardless of whether they had been forked or not.

Since the parent process does chdir("/") if it is appropriate, the
children will inherit that, so they don't need to chdir() at all.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: b61d0853c00bd08549d60a311394d82065e074fc
      https://github.com/acassen/keepalived/commit/b61d0853c00bd08549d60a311394d82065e074fc
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-26 (Sat, 26 Nov 2016)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/core/daemon.c
    M keepalived/core/main.c
    M keepalived/vrrp/vrrp_daemon.c

  Log Message:
  -----------
  Only set umask(0) in parent process

The children inherit it from the parent, so no need to set it in
the vrrp or checker child processes.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 1584eb440a4220a2f201ee04178f375a3db3ee93
      https://github.com/acassen/keepalived/commit/1584eb440a4220a2f201ee04178f375a3db3ee93
  Author: pqarmitage <[email protected]>
  Date:   2016-11-26 (Sat, 26 Nov 2016)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/core/daemon.c
    M keepalived/core/main.c
    M keepalived/vrrp/vrrp_daemon.c
    M lib/parser.c

  Log Message:
  -----------
  Merge pull request #470 from pqarmitage/fixes

Fix startup if in non-forking mode with relative path name to config file


Compare: https://github.com/acassen/keepalived/compare/0f41b606f901...1584eb440a42

------------------------------------------------------------------------------

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.