Re: [PATCH v4 05/11] driver core: Simplify API device_find_child_by_name() implementation
Zijun Hu <[email protected]>
| Newsgroups | gmane.linux.ports.sparc,gmane.linux.kernel,gmane.linux.sound,gmane.linux.block,gmane.linux.kernel.firewire.devel,gmane.linux.kernel.efi,gmane.linux.kernel.gpio,gmane.comp.video.dri.devel,gmane.linux.ports.arm.mediatek,gmane.linux.kernel.hwmon,gmane.linux.drivers.video-input-infrastructure,gmane.linux.pwm,gmane.linux.scsi,gmane.linux.usb.general,gmane.linux.serial,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
On 2024/12/24 04:39, Jonathan Cameron wrote: > There is a subtle difference. In theory old code could dereference a NULL > if parent->p == NULL, now it can't. Sounds at most like a harmless change but > maybe you should mention it. > i did not correct parameter checking for device_find_child_by_name() in below commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/core.c?id=903c44939abc02e2f3d6f2ad65fa090f7e5df5b6 since this commit will come finally, actually, this commit is the original motivation of this whole patch series. > Otherwise LGTM > Reviewed-by: Jonathan Cameron <[email protected]>