Re: [PATCH v4 10/11] cxl/pmem: Replace match_nvdimm_bridge() with API device_match_type()
Zijun Hu <[email protected]>
| Newsgroups | gmane.linux.pwm,gmane.linux.kernel,gmane.linux.sound,gmane.linux.ports.sparc,gmane.linux.block,gmane.linux.kernel.firewire.devel,gmane.linux.kernel.efi,gmane.linux.kernel.gpio,gmane.comp.video.dri.devel,gmane.linux.ports.arm.mediatek,gmane.linux.kernel.hwmon,gmane.linux.drivers.video-input-infrastructure,gmane.linux.scsi,gmane.linux.usb.general,gmane.linux.serial,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
On 2024/12/24 04:48, Jonathan Cameron wrote: >> From: Zijun Hu <[email protected]> >> >> Static match_nvdimm_bridge(), as matching function of device_find_child() >> matches a device with device type @cxl_nvdimm_bridge_type, and its task >> can be simplified by the recently introduced API device_match_type(). >> >> Replace match_nvdimm_bridge() usage with device_match_type(). >> >> Reviewed-by: Alison Schofield <[email protected]> >> Signed-off-by: Zijun Hu <[email protected]> > I don't see any uses of is_cxl_nvdimm_bridge() other than this one > Drop that as well? > will add a optional patch to drop is_cxl_nvdimm_bridge() in next revision. > This one is a bit of a trade off because the way is_cxl_nvdimm_bridge() > is identified is kind of an internal detail, but it's been true for a long > time so I'm fine with this change. > > Jonathan