Re: net: rnpgbe: Pass an expression directly in rnpgbe_rm_adapter()

Markus Elfring <[email protected]> Mon, 13 Jul 2026 08:00:43 +0200
Newsgroups gmane.linux.kernel.janitors,gmane.linux.network,gmane.linux.kernel
Message-ID <[email protected]>
>> The address of a data structure member was determined before
>> a corresponding null pointer check in the implementation of
>> the function “rnpgbe_rm_adapter”.
> 
> The null check in rnpgbe_rm_adapter() looks more like defensive
> programming,

This can be fine, can't it?


>              which got into the code unnoticed.

Some patch reviews happened accordingly.


>                                                 pdev will not exist if
> netdev is not allocated, where mucse is netdev private data.

Would you like to reconsider the relevance of another null pointer check?

Regards,
Markus