Re: [PATCH] cpufreq: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate()
Dan Carpenter <[email protected]> Mon, 13 Jul 2026 10:45:03 +0300
| Newsgroups | gmane.linux.kernel.janitors,gmane.linux.power-management.general,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Jul 12, 2026 at 09:30:16PM +0800, Zhongqiu Han wrote:
> On 7/11/2026 3:34 AM, Dan Carpenter wrote:
> > The clk_get_parent() function doesn't return error pointers, it returns
> > NULL on error. Update the error checking to match.
> >
> > Fixes: 420993221175 ("cpufreq: SPEAr: Add CPUFreq driver")
> > Signed-off-by: Dan Carpenter <[email protected]>
>
> Nice catch, thanks for the fix.
>
> Nit: the subject is too generic and can be misread as a cpufreq core
> fix. It is better to scope it to the driver, e.g. "cpufreq: spear: ...".
>
Oops. Sorry.
regards,
dan carpenter