Re: [PATCH] marker fixup for ltt-probe-*

Hi,

* Kevin Hilman ([email protected]) wrote:
> Fix up some markers in ltt-probe-* that were found when trying to load
> them as modules and getting -EPERM. Some are #ifdef XYZ in the kernel
> code but not in the , and others appear to be typos.
> 
> Patch is against today's git tree.
> 
> -       result = marker_set_probe("kernel_timer_update_time",
> -                       KERNEL_TIMER_UPDATE_TIME_FORMAT,
> -                       probe_kernel_timer_update_time);
> -       if (!result)
> -               goto cleanup;
> +       /* TODO: this is marked as TODO in kernel/timer.c */
> +/*     result = marker_set_probe("kernel_timer_update_time", */
> +/*                     KERNEL_TIMER_UPDATE_TIME_FORMAT, */
> +/*                     probe_kernel_timer_update_time); */
> +/*     if (!result) */
> +/*             goto cleanup; */
> 

I don't see any TODO in kernel/timer.c for the marker, should I apply this
one ?

Mathieu


OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68