Re: [PATCH 2/2] lttctl: Set correct state events channels on armall

* Jan Kiszka ([email protected]) wrote:
> Currently ltt-armall directs every marker event to the cpu channel. This
> patch starts distributing important state events to the related channels
> under control/. This helps, e.g., to keep track of process names in
> hybrid mode where the cpu channel is overwritten and only the control
> channels are read continuously.
> 
> Signed-off-by: Jan Kiszka <[email protected]>
> 
> ---
>  lttctl/ltt-armall.sh |   22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> Index: b/lttctl/ltt-armall.sh
> ===================================================================
> --- a/lttctl/ltt-armall.sh
> +++ b/lttctl/ltt-armall.sh
> @@ -11,4 +11,24 @@ MARKERS=`cat /proc/ltt|grep -v %k|awk '{
>  echo Connecting internal_kernel_sched_schedule
>  echo "connect internal_kernel_sched_schedule scheduler" > /proc/ltt
>  
> -for a in $MARKERS; do echo Connecting $a; echo "connect $a default" > /proc/ltt; done
> +for a in $MARKERS; do
> +	echo Connecting $a
> +
> +	#redirect markers carrying state information to dedicated channels
> +	case $a in
> +	list_process_state|user_generic_thread_brand|fs_exec|kernel_process_fork|kernel_process_free|kernel_process_exit|kernel_arch_kthread_create)

Yes, this is required. Thanks for providing this patch. Will apply.

Mathieu

> +		CHANNEL=processes
> +		;;
> +	list_interrupt)
> +		CHANNEL=interrupts
> +		;;
> +	kernel_module_load|kernel_module_free)
> +		CHANNEL=modules
> +		;;
> +	*)
> +		CHANNEL=
> +		;;
> +	esac
> +
> +	echo "connect $a default dynamic $CHANNEL" > /proc/ltt
> +done
> _______________________________________________
> Ltt-dev mailing list
> [email protected]
> http://listserv.shafik.org/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68