Re: [PATCH] EDAC/xgene: Use platform_get_irq() for IRQ lookup

On Fri, Aug 14, 2026 at 11:53:47AM +0700, [email protected] wrote:
> From: bui duc phuc <[email protected]>
> 
> The probe function propagates any negative return value from
> platform_get_irq_optional() and aborts the probe. Therefore, the
> optional IRQ semantics of platform_get_irq_optional() are not used
> here.
> 
> Use platform_get_irq() instead, which matches the existing error
> handling by propagating any IRQ lookup error.
> 
> platform_get_irq() also reports lookup errors itself, so remove the
> redundant error message from the driver.
> 
> Signed-off-by: bui duc phuc <[email protected]>
> ---
>  drivers/edac/xgene_edac.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
> index 9955396c9a52..aae7e03b0573 100644
> --- a/drivers/edac/xgene_edac.c
> +++ b/drivers/edac/xgene_edac.c
> @@ -1915,9 +1915,8 @@ static int xgene_edac_probe(struct platform_device *pdev)
>  		int i;
>  
>  		for (i = 0; i < 3; i++) {
> -			irq = platform_get_irq_optional(pdev, i);
> +			irq = platform_get_irq(pdev, i);
>  			if (irq < 0) {
> -				dev_err(&pdev->dev, "No IRQ resource\n");
>  				rc = irq;
>  				goto out_err;
>  			}
> -- 

So this driver received a new maintainer here:

49b35cd5e7dd ("MAINTAINERS: Update Ampere email address")

and I don't remember seeing it. But ok, water under the bridge, that's looong
time ago.

Sashiko reports a bunch of preexisting issues:

https://sashiko.dev/#/patchset/20260814045347.13841-1-phucduc.bui%40gmail.com

which need to be addressed before anything else.

So let's see if Khuong responds. Otherwise, I'm marking this driver as orphan
too and we're done with more obsolete stuff.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette