Re: [PATCH v2] ver_linux: add comparison with required version and add rows and colour to output
Randy Dunlap <[email protected]>
| Newsgroups | gmane.linux.kernel.workflows,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi, On 8/14/26 7:32 AM, Manuel Ebner wrote: > Add the required version from changes.rst. > Add code for comparison and print '###' in the respective row (good, bad) and in > the respective colour (blue, green, red) depending on the result of the comparison. > I find the dark blue difficult to read (on a black background). > Signed-off-by: Manuel Ebner <[email protected]> > --- > [v2] > add colour reset as Geert suggested > change output to take colourblindness into account > --- > scripts/ver_linux | 112 ++++++++++++++++++++++++++-------------------- > 1 file changed, 63 insertions(+), 49 deletions(-) > Other small-ish issues: binutils version 2.45.0.20251103-4 doesn't fit into its column. Not so small issue: The version number comparison doesn't know/care about decimal points/fractions etc., so: gdb 16.3 7.2 ### <<<<< RED because 1 < 7. and GNU C 16 8.1 ### <<<<< RED jfsutils 1.1.15 1.1.3 ### <<<<< RED Python 3.13.14 3.9.0 ### <<<<< RED -- ~Randy