Re: Development docbook-xsl-ns page issues

On Thu, 8 May 2025 22:05:44 -0500
"Bruce Dubbs" ([email protected] via blfs-dev Mailing List) <[email protected]> wrote:

> On 5/8/25 9:50 PM, William Harrington ([email protected] via blfs-dev Mailing 
> List) wrote:
> > Greetings,
> > 
> > Didn't have these issues in the stable 12.3 book, however when going through the development book I've noticed the following:
> > 
> > https://www.linuxfromscratch.org/blfs/view/systemd/pst/docbook-xsl-ns.html
> > 
> > Missing quote:
> > 
> > xmlcatalog --noout --add "rewriteSystem"                   \
> >             "http://cdn.docbook.org/release/xsl/current     \
> >             "/usr/share/xml/docbook/xsl-stylesheets-1.79.2" \
> >             /etc/xml/catalog
> > 
> > This block is missing a " after http://cdn.docbook.org/release/xsl/current
> > 
> > 
> > Strange character after "http://cdn.docbook.org/release/xsl/current"    \:
> > xmlcatalog --noout --add "rewriteURI"                      \
> >             "http://cdn.docbook.org/release/xsl/current"    \ <----- bad character after \ here
> >             "/usr/share/xml/docbook/xsl-stylesheets-1.79.2" \
> >             /etc/xml/catalog
> 
> Thank you.  I just pushed a fix for both issues.  It will be rendered overnight.
> 
> That bad character was a space.  Those can be difficult to spot.
> 
>    -- Bruce
> 

Thank you, Bruce

I've found out when using my own scripts and testing builds that https://www.shellcheck.net/ or a local shell check helps find issues.

I know when we edit that we do a quick commit, then we forgot to check to see if it actually works.

The main thing is to not commit broken scripts or code. Before a commit at least check to see if the change fixes the problem, then commit.

Sincerely,

William Harrington

-- 
http://lists.linuxfromscratch.org/sympa/info/blfs-dev
Unsubscribe: See the above information page