Re: Today's changes didn't compile
Felix von Leitner <[email protected]> Thu, 3 Oct 2019 21:22:33 +0200
| Newsgroups | gmane.linux.lib.dietlibc |
|---|---|
| Message-ID | <[email protected]> |
> for today's changes I required some kind of brute force patches via > standards checking to build dietlibc. Then your build environment is broken. $ make -s CC="gcc -std=gnu99" $ gcc -v [...] gcc version 7.3.0 (GCC) $ It also builds with gcc 9.2.0. Note that C90 is no longer supported as the code uses C++-style comments all over the place now. But using a dietlibc built with a newer gcc to build binaries on an older system should also work fine. > dietlibc frank 21:07:05$ cat dietlibc-20191003-c11-fixes.patch These are _not_ fixes. > --- include/uchar.h.orig 2019-10-03 17:39:15.000000000 +0200 > +++ include/uchar.h 2019-10-03 21:01:35.000000000 +0200 > @@ -1,3 +1,4 @@ > +#if __STDC_VERSION__ >= 201112L > #ifndef _UCHAR_H > #define _UCHAR_H > > @@ -33,3 +34,5 @@ > __END_DECLS > > #endif > +#endif > + Please stop posting "fixes" like this on the mailing list. You are more likely to cause confusion and/or brokenness than fixing anything. If you want to report a problem, report the problem, not your "fix". Especially not if it consists of commenting out whole files wholesale. Felix