Re: Today's changes didn't compile

On Thu, Oct 03, 2019 at 09:22:33PM +0200, Felix von Leitner wrote:
> Then your build environment is broken.
> 
> $ make -s CC="gcc -std=gnu99"
> $ gcc -v
> [...]
> gcc version 7.3.0 (GCC)
> $
> 
> It also builds with gcc 9.2.0.

This is about neccessity but not sufficiency.

> Note that C90 is no longer supported as the code uses C++-style comments
> all over the place now. But using a dietlibc built with a newer gcc to
> build binaries on an older system should also work fine.

I also use C99 (with the exception of VLAs because they did break this
standard). But not C11. Even if this better now reg. VLAs. ;-)

> > dietlibc frank 21:07:05$ cat dietlibc-20191003-c11-fixes.patch
> 
> These are _not_ fixes.

Let me phrase it differently: The macro checks did the build for ME. ;-)

> Please stop posting "fixes" like this on the mailing list.

Ouch! Sorry, yes. It won't happen again.

> You are more likely to cause confusion and/or brokenness than fixing
> anything.
> 
> If you want to report a problem, report the problem, not your "fix".
> Especially not if it consists of commenting out whole files wholesale.

My problem was that I don't use a C11 compiler.
Actually the "process of cvs update" is broken in that way that if you
already have a cvs checkout and you do a cvs up then you normally don't
check for updated docs. If you start from scratch by visiting your website
and reading the docs it is different...
Actually I was just doing cvs up without knowing that I need a C11 compiler.
That's why I added macro checks for it to be able to "fully" compile diet
after updating to a C11 compiler.
No issue.

Again please take my pardon.


-- 
EDV Frank Bergmann                           Tel.     +49-5221-9249753
LPIC-3 Linux Professional                    Fax      +49-5221-9249754
Pödinghauser Str. 5                          email    [email protected]
D-32051 Herford                              USt-IdNr DE237314606