Re: [PATCH v6 2/4] fw_load: rewrite test using new LTP API

Hi Cyril,

> If you are splitting the tst_res() by the fw->fake then do it right. We
> should drop the && !fw->fake from the fail above and use a variable
> only to get the right bit from the result:
> 
> int pass = result && (1<<i);
> 
> if (fw->fake)
> 	tst_res(pass ? TFAIL : TPASS, ...)
> else
> 	tst_res(pass ? TPASS : TFAIL, ...)

Much cleaner indeed, I will fix it.

> 
> I assume that we dropped this because we have
> tst_requires_module_signature_disabled() later in the setup() right?

Exactly.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato-IBi9RG/[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp