Re: [PATCH v6 4/4] fw_load: add fw_load02 for custom firmware path
Andrea Cervesato via ltp <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
Hi Cyril, > These functions are nearly identical to the fw_load01.c maybe we should > put them into a header and include it into both tests instead? > > I guess that we can have a static inline function do_test() that would > take the fw_data and fw_count as an argument and call it from run(). The > same for create_firmare(). We can pas sthe fw_data pointer that would be > initialized instead of acting on globals and put it into the shared > header. We can simply share a do_test() in the header indeed, but the setup() part should stay like it is now, because only a tiny bit is actually overlapping. I will send a new patch. Regards, -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato-IBi9RG/[email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp