Re: fs/acl: Add ACL_USER_OBJ permission test
Andrea Cervesato via ltp <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
> On 15/06/26 2:34 pm, Andrea Cervesato wrote: > > Also, please don't define SAFE_* macros inside the tests, their > > are part of the core library and they should not be defined out > > of it. Instead, use inline functions. > I think you are referring to SAFE_TRY_UNLINK/RMDIR implemented in acl_lib.h Yes > > Apart from acl tests no other test use it today. In future there may be > additional users. > Would it make sense to move them to lib/safe_macros (tst_safe_macros)? No, it's better to keep them inside the tests. The SAFE_* functions are meant to be as atomic as possible. -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato-IBi9RG/[email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp