Re: [PLF-announce] [RPM] hheretic-0.2.0-1plf2010.0

Zombie Ryushu wrote:
> Name        : hheretic                     Relocations: (not relocatable)
> Version     : 0.2.0                             Vendor: Penguin Liberation Front
> Release     : 1plf2010.0                    Build Date: ven. 14 ao?t 2009 07:41:51 CEST
> Install Date: (not installed)               Build Host: cooker64.home.nanardon.zarb.org
> Group       : Games/Arcade                  Source RPM: (none)
> Size        : 467853                           License: GPL

Non-specific license, see Mandriva licensing policy.

> Signature   : (none)
> Packager    : Zombie Ryushu <[email protected]>
> URL         : http://hheretic.sourceforge.net/
> Summary     : Hacked Heretic is a Linux port of Raven Games old shooter, Heretic
> Description :
> Hacked Heretic is a Linux port of Raven Game's old shooter, Heretic.
> 
> This is a new release of Dan's excellent Hacked Heretic, by the
> authors of Hammer of Thyrion (Heretic II). We're applying fixes,
> adding a few features, and ensuring it runs on most *nix operating
> systems.
> 
> This package contains the OpenGL enabled binary.
> 
> This application is PLF Because it requires non-free data.

Not a good reason to include in PLF, should be in Mandriva repositories.

> Toni Graffy <[email protected]> - 1.5.3-0.pm.1:
> - update to 1.5.3

No changelog.

> # Copyright (c) 2008-2009 oc2pus
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # Please submit bugfixes or comments to [email protected]
> 
> # norootforbuild

Opensuse flag, not needed for Mandriva.

> %define _prefix	/usr

Not needed.

> %define distsuffix	plf
> 
[...]
> Vendor:         Penguin Liberation Front
> Packager:       Zombie Ryushu <[email protected]>

Vendor and Packager tags are not allowed in .specs.

> URL:			http://hheretic.sourceforge.net/
> Source:			http://downloads.sourceforge.net/hheretic/%{name}-%{version}-src.tgz
> Source1:		%{name}.png
> Source90:		%{name}-rpmlintrc
> BuildRoot:		%{_tmppath}/%{name}-%{version}-build
> BuildRequires:	GL-devel
> BuildRequires:	SDL-devel >= 1.2.4
> BuildRequires:	SDL_mixer-devel >= 1.2.4
> Requires:	timidity

No package provides timidity.

> %description
[...]
> This package contains the OpenGL enabled binary.
[...]
> %package sdl
> Summary:	Hacked Heretic is a Linux port of Raven Game's old shooter, Heretic
> Group:		Amusements/Games/Action/Shoot

Invalid group.

> %description sdl
[...]
> This package contains the sdl enabled binary.

What's the difference between sdl and OpenGL binaries? This should be
explained in descriptions.

> %package demo
> Summary:	Hacked Heretic is a Linux port of Raven Game's old shooter, Heretic
> Group:		Amusements/Games/Action/Shoot

Invalid group.

> Requires:	%{name}
> 
> %description demo
> Hacked Heretic is a Linux port of Raven Game's old shooter, Heretic.
> 
> Those without the full retail version of Heretic can still play the
> demo.
> 
> 
> %prep
> %setup -q -n %{name}-%{version}-src
> 
> %build
> # compile the OpenGL version (hheretic-gl)
> %configure \
> 	--with-audio=sdlmixer
> %__make %{?jobs:-j%{jobs}}

%make

> # compile the software version (hheretic-sdl)
> %__make clean
> %configure \
> 	--disable-gl \
> 	--with-audio=sdlmixer
> %__make %{?jobs:-j%{jobs}}

%make

> %install
> # wrapper startscript
> %__install -dm 755 %{buildroot}%{_bindir}
[...]
> 
> 	%__install -m 755 %{name}-$i.sh \
> 		%{buildroot}%{_bindir}
> done

Belongs to %_gamesbindir.

> # install the gamedata
> %__install -dm 755 %{buildroot}/%{_datadir}/games/%{name} \
> 	%{buildroot}%{_datadir}/games/%{name}

Use %{_gamesdatadir}.

> %__install -dm 755 %{buildroot}%{_prefix}/games/%{name}

This is very strange and seems unneeded.

> %__install -dm 755 %{buildroot}%{_datadir}/pixmaps
> for i in gl sdl; do
> 	# binaries
> 	%__install -m 755 %{name}-$i \
> 		%{buildroot}%{_prefix}/games
> 
> 	# icon
> 	 %__install -m 644 %{SOURCE1} \
> 	 	%{buildroot}%{_datadir}/pixmaps/%{name}-$i.png
> done
> 
> # install menu entry
> %__install -dm 755 %{buildroot}%{_datadir}/applications
> %{__cat} > %{name}-gl.desktop << EOF
> [Desktop Entry]
> Name=Hacked Heretic (OpenGL)
> GenericName=Hacked Heretic (OpenGL)
> Comment=Hacked Heretic is a Linux port of Raven Game's old shooter, Heretic
> Exec=%{name}-gl.sh
> Icon=%{name}-gl
> Terminal=false
> Type=Application
> #Encoding=UTF-8

Why keep this commented line?

[...]
> 
> %__install -m 644 %{name}*.desktop \
> 	%{buildroot}%{_datadir}/applications
> 
> %clean
> [ -d "%{buildroot}" -a "%{buildroot}" != "" ] && %__rm -rf "%{buildroot}"
> 
[...]
> %files demo
> %defattr(-,root,root)
> # %doc README.demowad
> # %dir %{_datadir}/games/%{name}
> # %{_datadir}/games/%{name}/*.wad

Why create this empty package??

-- 
Anssi Hannula