Re: [PLF-announce] [RPM] deng-1.9.0~beta6.3-1plf2010.0

Zombie Ryushu wrote:
> Name        : deng                         Relocations: (not relocatable)
> Version     : 1.9.0~beta6.3                     Vendor: Penguin Liberation Front
> Release     : 1plf2010.0                    Build Date: ven. 14 ao?t 2009 07:39:29 CEST
> Install Date: (not installed)               Build Host: cooker64.home.nanardon.zarb.org
> Group       : Games/Arcade                  Source RPM: (none)
> Size        : 4811100                          License: GPL2

"GPL2" is not a Mandriva license name.

[...]

> This application is PLF because it requires non-free data.

AFAICS not a reason enough, this should be put in Mandriva contrib or
non-free.

> - jengelh:
> - new upstream release: 1.9.0~beta6.1

Changelog entry is missing.

[...]
> Vendor:         Penguin Liberation Front
> Packager:       Zombie Ryushu <[email protected]>

These should not be defined in .spec.
[...]
> Suggests:	TiMidity
> Provides:	jdoom = %version-%release
> Provides:	jheretic = %version-%release
> Provides:	jhexen = %version-%release
> %if "%{?vendor_uuid}" != ""
> Provides:	jdoom(vendor=%vendor_uuid) = %version-%release
> Provides:	jheretic(vendor=%vendor_uuid) = %version-%release
> Provides:	jhexen(vendor=%vendor_uuid) = %version-%release
> %endif

What is %vendor_uuid?

> %description
[...]

> cmake .. -DCMAKE_INSTALL_PREFIX=/opt/%name -Dlibdir=/opt/%name/libexec \
> 	-Ddatadir=/opt/%name

Use %cmake. Also, there is no reason to install this into /opt.

> make %{?jobs:-j%jobs};

Use %make.

> popd;
> popd;
> 
> %install
> b="%buildroot";
> rm -Rf "$b";
> mkdir "$b";
> mkdir -p "$b/%_prefix/games";

Use %_gamesbindir.

> pushd doomsday/obj/;
> make install DESTDIR="$b";

Use %makeinstall_std.

> popd;
> ln -s /opt/%name/bin/doomsday "$b/%_prefix/games/";
[...]

-- 
Anssi Hannula