Re: [patch] arptables Makefile cleanup and honour DESTDIR

В Срд, 15/08/2007 в 16:28 +0200, Bart De Schuymer пишет: 
> Looks good, applied. I'm wondering: don't you want
> 
> $(DESTDIR)$(MANDIR)/man8/arptables.8: arptables.8
> 	mkdir -p $(@D)
> 	install -m 0644 -o root -g root $< $@
> 
> instead of
> 
> $(MANDIR)/man8/arptables.8: arptables.8
> 	mkdir -p $(DESTDIR)$(@D)
> 	install -m 0644 -o root -g root $< $(DESTDIR)$@
> 
> ?

I've tried to generate Makefile.in with automake and found that there
are no such things in generated Makefile. So while I do not know the
answer on the question "what is right" I'm sure that for purposes
DESTDIR was supposed to be created
http://www.gnu.org/prep/standards/html_node/DESTDIR.html#DESTDIR
the $(DESTDIR)$(MANDIR) is not required.

> > BTW. arptables-0.0.3-2 does not compiles with the recent kernels. Is
> > there any ETA for new release?
> 
> I'll release 0.0.3-3 as soon as the above question is resolved :)

Great. I do not think this issue should stop the release. tcpdump,
arpwatch and other projects does not do that, so while may be
$(DESTDIR)$(MANDIR) is better, I do not know this for sure and I'd avoid
doing that in Makefile without getting any answer from really Makefile
gurus. I'll try to ask automake mailing list are there any reasons not
to do that, and report you results. But it's summer now so we'll see if
there will be any answer. 

-- 
Peter.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

_______________________________________________
Ebtables-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ebtables-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBGxRRcz6tlgEWSarMRAqCQAJ91OgDxb5G6qYnYl3qGFUKirRLSfQCfSoNO
3Qs6Kes9AeBlR1gqOUjnFPM=
=XKPZ
-----END PGP SIGNATURE-----