Re: [patch] arptables Makefile cleanup and honour DESTDIR

Peter Volkov <[email protected]>
Newsgroups gmane.linux.network.bridge.ebtables.devel
Message-ID <1187407342.16509.65.camel@localhost>
Hello, Bart.

В Срд, 15/08/2007 в 16:28 +0200, Bart De Schuymer пишет:
> Looks good, applied. I'm wondering: don't you want
> $(DESTDIR)$(MANDIR)/man8/arptables.8: arptables.8
> ?

As I told you I've mailed automake mailing list and here is the answer:
http://lists.gnu.org/archive/html/automake/2007-08/msg00102.html
This means that using 
$(DESTDIR)$(MANDIR)/man8/arptables.8: arptables.8
could be better in ebtables case. If you wish to do that, possible
implementation applied.

-- 
Peter.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

_______________________________________________
Ebtables-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ebtables-devel
arptables-makefile.diff (text/x-patch, 763 B)
--- ./Makefile.orig	2007-08-18 07:15:27.000000000 +0400
+++ ./Makefile	2007-08-18 07:18:54.000000000 +0400
@@ -41,17 +41,16 @@
 arptables: arptables-standalone.o arptables.o libarptc/libarptc.o $(EXT_OBJS)
 	$(CC) $(CFLAGS) -o $@ $^
 
-$(MANDIR)/man8/arptables.8: arptables.8
+$(DESTDIR)$(MANDIR)/man8/arptables.8: arptables.8
 	mkdir -p $(DESTDIR)$(@D)
 	install -m 0644 -o root -g root $< $(DESTDIR)$@
 
-.PHONY: exec
-exec: arptables
+$(DESTDIR)$(BINDIR)/arptables: arptables
 	mkdir -p $(DESTDIR)$(BINDIR)
 	install -m 0755 -o root -g root $< $(DESTDIR)$(BINDIR)/arptables
 
 .PHONY: install
-install: $(MANDIR)/man8/arptables.8 exec
+install: $(DESTDIR)$(MANDIR)/man8/arptables.8 $(DESTDIR)$(BINDIR)/arptables
 
 .PHONY: clean
 clean:
signature.asc (application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBGxmXtz6tlgEWSarMRAtg+AJ9SPWUuHmiE80UJDnl/iyb540c50wCcChR9
fbYjIJYggfKpJWZDn38gwm0=
=YaJ5
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.