Re: [PATCH v2 04/11] arch_topology: Reset all cpus in reset_cpu_topology

Jiaxun Yang <[email protected]> Tue, 14 Apr 2020 16:35:14 +0800
Newsgroups gmane.linux.ports.mips,gmane.linux.kernel,gmane.linux.oprofile,gmane.linux.power-management.general
Message-ID <[email protected]>
On Tue, 14 Apr 2020 09:27:34 +0100
Sudeep Holla <[email protected]> wrote:

> On Sun, Apr 12, 2020 at 11:20:34AM +0800, Jiaxun Yang wrote:
> > For MIPS platform, when topology isn't probed by DeviceTree,
> > possible_cpu might be empty when calling init_cpu_topology,
> > that may result cpu_topology not fully reseted for all CPUs.
> > So here we can reset all cpus instead of possible cpus.
> >  
> 
> As I have told before adjust and make it default before this function
> gets called.

Hi,

That's really impossible under current MIPS code structure.

Another option would be prefill possible_cpu with all_cpu_mask before
calling topology_init, but that would make the code unnecessarily
complex.

Here simply reset the whole array won't cause any regression.

Thanks.
> 
--
Jiaxun Yang