Re: [PATCH v2 01/11] MIPS: setup: Drop prefill_possible_map
Jiaxun Yang <[email protected]> Tue, 14 Apr 2020 16:39:57 +0800
| Newsgroups | gmane.linux.ports.mips,gmane.linux.kernel,gmane.linux.oprofile,gmane.linux.power-management.general |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 14 Apr 2020 09:21:36 +0100 Sudeep Holla <[email protected]> wrote: > On Sun, Apr 12, 2020 at 11:20:31AM +0800, Jiaxun Yang wrote: > > All the plat_smp_setup are setting up possible cpus in their > > platform code. So prefill_possible_map is actually overwriting > > platform's setup, which seems unreasonable. > > > > Why don't you rearrange the code so that this still remains as is and > the platforms can override if they need. If you do so, you don't need > the change in 04/11 as I suggested previously. Actually this code break a case that cpumask is not continuous. It do happen on some MIPS platforms. Yes. rearrange this is a option but I think it is making the logic unnecessarily complex. If you think that's better I'll do so. Thanks. > -- Jiaxun Yang