Re: chage -l

On Tue, 9 Aug 2005, Nicolas [iso-8859-1] François wrote:

> Hello,
>
> Tomasz, can you also have a look at the 427 Debian patch.
>
> It also changes chage in a similar way.
>
> The "Last password change" interpretation is also modified:
> lastday of 0 means that the password must be changed.
>
>> @@ -266,7 +266,7 @@
>>  	 */
>>
>>  	printf (_("Password inactive\t\t\t\t\t: "));
>> -	if (lastday <= 0 || inactdays <= 0 ||
>> +	if (lastday <= 0 || inactdays < 0 ||
>>  	    maxdays >= 10000 * (DAY / SCALE) || maxdays <= 0) {
>
> It's also probably "maxdays < 0" instead of "maxdays <= 0"
>
>>  		printf (_("never\n"));
>>  	} else {
>
> IMO, all these modifications are consistent with the pam_unix module.

Looks like this change is also for commit.
I'm prepare also some fixes for chage man page:

Index: chage.1.xml
===================================================================
RCS file: /cvsroot/shadow/man/chage.1.xml,v
retrieving revision 1.12
diff -u -u -r1.12 chage.1.xml
--- chage.1.xml 9 Aug 2005 13:31:38 -0000       1.12
+++ chage.1.xml 9 Aug 2005 16:52:54 -0000
@@ -60,10 +60,11 @@
              accounted is locked. The date may also be expressed in the
              format YYYY-MM-DD (or the format more commonly used in your
              area). A user whose account is locked must contact the system
-            administrator before being able to use the system again. Passing
-            the number <emphasis remap='I'>-1</emphasis> as the <emphasis
-            remap='I'>EXPIRE_DATE</emphasis> will remove an accounts
-            expiration date.
+            administrator before being able to use the system again.
+         </para>
+         <para>
+           Passing the number <emphasis remap='I'>-1</emphasis> as the <emphasis
+           remap='I'>EXPIRE_DATE</emphasis> will remove an account expiration date.
            </para>
          </listitem>
        </varlistentry>
@@ 
-76,9 +78,12 @@
              Set the number of days of inactivity after a password has
              expired before the account is locked. The <emphasis
              remap='I'>INACTIVE</emphasis> option is the number of days of
-            inactivity. A value of -1 disables this feature. A user whose
-            account is locked must contact the system administrator before
-            being able to use the system again.
+            inactivity. A user whose account is locked must contact the system
+           administrator before being able to use the system again.
+         </para>
+         <para>
+           Passing the number <emphasis remap='I'>-1</emphasis> as the <emphasis
+           remap='I'>INACTIVE</emphasis> will remove an accounts inactivity.
            </para>
          </listitem>
        </varlistentry>
@@ -117,6 +122,10 @@
              to use her account. This occurrence can be planned for in
              advance by use of the <option>-W</option> option, which provides
              the user with advance warning.
+          </para>
+         <para>
+           Passing the number <emphasis remap='I'>-1</emphasis> as the <emphasis
+           remap='I'>MAX_DAYS</emphasis> will remove checking an password validation.
            </para>
          </listitem>
        </varlistentry>

kloczek
PS. Cc: to Peter Vrabec because he is not subscribed.
-- 
-----------------------------------------------------------
*Ludzie nie majÂą problemĂłw, tylko sobie sami je stwarzajÂą*
-----------------------------------------------------------
Tomasz KÂłoczko, sys adm @zie.pg.gda.pl|*e-mail: [email protected]*