Re: shadow fails to compile with gcc-2

On Sun, 4 Sep 2005, Mike Frysinger wrote:

> On Sunday 04 September 2005 03:23 pm, Tomasz KÂłoczko wrote:
>> On Sun, 4 Sep 2005, Mike Frysinger wrote:
>> [..]
>>
>>>> but understand also me: I want keep shadow code in best readable form.
>>>> Current form in this area is IMO better.
>>>
>>> yeah, the current form is def more readable than the version the previous
>>> patch changed it to
>>>
>>> how about this patch instead ?
>>
>> Better but .. it can't be only +two lines patch because I keep all code
>> possibly indented (try apply your patch and run "indent newgrp.c" :)
>
> i was going to leave such fun details to you ;)
>
> i just wanted to see if the idea of scoping the code was acceptable to you
>
>> I can put your previouse patch in dist tar ball in next release [1] (in
>> contrib/ subdirectory) and any other version updated this patch for gcc-2
>> (?).
>
> prob would be helpful to people if you're not interested in adding scope to
> the pam code

OK. This can't hurd anythindg .. one file more or less :)

Current code is to fragmented (in sense number conditionas sections). In 
current release you will find some chenges commented as "consolidate two 
sections of code #ifndef USE_PAM to one." (or similar).

For example in login.c number of conditions makes this file non-indentable 
(indent command can't correctly indent this .. plain proof using to
many conditions :>).
So firs: any kind of modyfications wchich will allow reduce number of 
conditionaly included parts of code and/or which will consolidade two or 
more parts of by some kinf of reordering will be acceptable.

kloczek
PS. I'll commit your patch to contrib/ in last day before release .. only 
just for case you or someone other will find better solution :)
-- 
-----------------------------------------------------------
*Ludzie nie majÂą problemĂłw, tylko sobie sami je stwarzajÂą*
-----------------------------------------------------------
Tomasz KÂłoczko, sys adm @zie.pg.gda.pl|*e-mail: [email protected]*