Re: [PATCH v8 10/12] accel/rocket: add RK3576 NPU (RKNN) support
Uwe Kleine-König <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.ports.arm.rockchip,gmane.linux.power-management.general,gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <aoQdns-GHS3fg5BJ@monoceros> |
Hello, On Mon, Aug 17, 2026 at 11:36:01PM +1200, Jiaxing Hu wrote: > diff --git a/drivers/accel/rocket/rocket_drv.h b/drivers/accel/rocket/rocket_drv.h > index 2c673bb99..0096c4ab1 100644 > --- a/drivers/accel/rocket/rocket_drv.h > +++ b/drivers/accel/rocket/rocket_drv.h > @@ -6,10 +6,12 @@ > > #include <drm/drm_mm.h> > #include <drm/gpu_scheduler.h> > +#include <linux/mod_devicetable.h> Please don't use <linux/mod_devicetable.h> but <linux/device-id/of.h>. The former is a mixture of many subsystem specifics and thus a dependency-hog. Best regards Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqEHtYACgkQj4D7WH0S /k4U9gf/aUhrYYFY54POvnsxnelsCZk9pbdIP6pqEh4NpwVQM+NfUIh1SYqcLXIf NqdrFegte49P8wGlByYbp2BP8P+Vh/KdPn+VPTi15o5ivhF6/lS1s3Smp5hwDS1N lDMzlLblQBoye2bS2VSkmaaJyzaZEARrJK3GOBpmc8PXGkMOFRFgF+ZgXiyEC91u E3rOSqRX153lKJWaHX3SH4yO0RUjN22sW6htFUwQZTm4iLRG6IzaP2+BM2cpWnCe I4RwXW6GaPue9NnC/Bf/659cN68fjK7fUU5JJn80cMtfO47GjXmA3ceX28vIB/rm WKAMBlhKd47VGV36uZrPNREsoz3v8g== =ee9u -----END PGP SIGNATURE-----