Re: [PATCH 1/4] drm/vc4: Drop the undocumented brcm,vc4-v3d compatible
Krzysztof Kozlowski <[email protected]>
| Newsgroups | gmane.linux.drivers.devicetree,gmane.comp.video.dri.devel,gmane.linux.kernel.rpi,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <20260818-tidy-melodic-sidewinder-e60360@quoll> |
On Sun, Aug 16, 2026 at 11:05:40AM -0300, Maíra Canal wrote:
> "brcm,vc4-v3d" is the compatible string V3D support originally shipped
> with in commit d3f5168a0810 ("drm/vc4: Bind and initialize the V3D
> engine."). Commit 90d7116061f8 ("drm/vc4: Recognize a more specific
> compatible string for V3D.") added "brcm,bcm2835-v3d" in v4.6 and kept
> the original one around, because the Raspberry Pi firmware was shipping
> device trees that used it.
>
> That string was never part of the binding: the documentation added in
> commit 4653f22e9ab0 ("dt-bindings: Add binding docs for V3D.") describes
> only "brcm,bcm2835-v3d", and no upstream device tree has ever used
> "brcm,vc4-v3d": the first in-tree V3D node, from commit 49ac67e0c39c
> ("ARM: bcm2835: Add VC4 to the device tree."), already carried the
> specific name. The firmware device trees the compatible was kept for
> predate v4.6, released in 2016.
>
> Drop it from both match tables.
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof