[aegl:resctrl2_v64 5/5] fs/resctrl2/monitor.c:67:6: warning: no previous prototype for 'remove_one_file'

kernel test robot <[email protected]>
Newsgroups gmane.linux.ports.ia64
Message-ID <[email protected]>
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git resctrl2_v64
head:   ae4a417f18e2317ad0ffbbf1b2a337277d9cd212
commit: ae4a417f18e2317ad0ffbbf1b2a337277d9cd212 [5/5] resctrl2: CPU hot plug fixes
config: i386-randconfig-i062-20230703 (https://download.01.org/0day-ci/archive/20230707/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230707/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> fs/resctrl2/monitor.c:67:6: warning: no previous prototype for 'remove_one_file' [-Wmissing-prototypes]
      67 | void remove_one_file(struct resctrl_resource *r, struct resctrl_group *rg, int id,
         |      ^~~~~~~~~~~~~~~

sparse warnings: (new ones prefixed by >>)
>> fs/resctrl2/monitor.c:67:6: sparse: sparse: symbol 'remove_one_file' was not declared. Should it be static?


vim +/remove_one_file +67 fs/resctrl2/monitor.c

    66	
  > 67	void remove_one_file(struct resctrl_resource *r, struct resctrl_group *rg, int id,
    68			     struct list_head *h)
    69	{
    70		struct kernfs_node *parent_kn = rg->mondata;
    71		struct resctrl_node_info *rni;
    72		struct kernfs_node *kn;
    73		char name[20];
    74	
    75		sprintf(name, r->mon_domain_dir, id);
    76		kn = kernfs_find_and_get_ns(parent_kn, name, NULL);
    77		if (!kn)
    78			return;
    79		kn = kernfs_find_and_get_ns(kn, r->mon_domain_file, NULL);
    80		if (!kn)
    81			return;
    82		rni = kn->priv;
    83		atomic_inc(&rni->waitcount);
    84		rni->flags |= RESCTRL_DELETED;
    85		kernfs_remove(kn);
    86		list_add(&rni->clean_list, h);
    87	}
    88	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.