Re: [PATCH] irqchip/jcore-aic: Fix missing allocation of IRQ descriptors
Geert Uytterhoeven <[email protected]>
| Newsgroups | gmane.linux.ports.sh.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <CAMuHMdXmtfCir4dt6CKe2YxDN53nNAcE=i5oyMkOsPavJ-p0Tw@mail.gmail.com> |
Hi Adrian, On Wed, May 10, 2023 at 6:36 PM John Paul Adrian Glaubitz <[email protected]> wrote: > The initialization function for the J-Core AIC aic_irq_of_init() is > currently missing the call to irq_alloc_descs() which allocates and > initializes all the IRQ descriptors. Add missing function call and > return the error code from irq_alloc_descs() in case the allocation > fails. > > Fixes: 981b58f66cfc ("irqchip/jcore-aic: Add J-Core AIC driver") > Signed-off-by: John Paul Adrian Glaubitz <[email protected]> Thanks for your patch! I am not an IRQ expert, so I'd like to leave the technical parts for e.g. Marc. But I think you should add to the description that this is based on a patch by Rich. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds