Re: [PATCH] irqchip/jcore-aic: Fix missing allocation of IRQ descriptors

Hi Geert!

On Thu, 2023-05-11 at 16:35 +0200, Geert Uytterhoeven wrote:
> Hi Adrian,
> 
> On Wed, May 10, 2023 at 6:36 PM John Paul Adrian Glaubitz
> <[email protected]> wrote:
> > The initialization function for the J-Core AIC aic_irq_of_init() is
> > currently missing the call to irq_alloc_descs() which allocates and
> > initializes all the IRQ descriptors. Add missing function call and
> > return the error code from irq_alloc_descs() in case the allocation
> > fails.
> > 
> > Fixes: 981b58f66cfc ("irqchip/jcore-aic: Add J-Core AIC driver")
> > Signed-off-by: John Paul Adrian Glaubitz <[email protected]>
> 
> Thanks for your patch!
> 
> I am not an IRQ expert, so I'd like to leave the technical parts for
> e.g. Marc.  But I think you should add to the description that this
> is based on a patch by Rich.

Will do! Thanks for the suggestions! I read through the IRQ source code
and checked what other architectures do and I think the first parameter
should be "-1" not 0.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913