Re: New procps release soon

"Craig Small" <[email protected]> ("csmall") Mon, 30 Sep 2024 17:45:54 +1000
Newsgroups gmane.linux.procps.devel
Message-ID <CALy8Cw5nHmwxRjyWje8OJxWhvZXn1vQw9sAf8KJ5=md7pg6m4g@mail.gmail.com>
--000000000000b0a90a0623516535
Content-Type: text/plain; charset="UTF-8"

On Wed, 25 Sept 2024 at 21:14, Dr. Werner Fink <[email protected]> wrote:

>
> I've got two patches from our glibc maintainer
>
>  procps-ng-4.0.4-idletime-no-tty.patch
>  procps-ng-4.0.4-w-array-bounds.patch
>
Thanks Werner (and glibc maintainer),
 They're now committed. Hadn't thought of the length of string
sd_session_get_tty returns.

One question though, won't that mean the destination string is not nul
terminated if the source string is longer than UT_LINESIZE?
It won't overwrite because it will break out of the for loop now, but
wasn't sure if it would be terminated.

 - Craig

--000000000000b0a90a0623516535
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, 25 Sept 2024 at 21:14, Dr. Werner=
 Fink &lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt; wrote:</=
div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex"><br>
I&#39;ve got two patches from our glibc maintainer<br>
<br>
=C2=A0procps-ng-4.0.4-idletime-no-tty.patch<br>
=C2=A0procps-ng-4.0.4-w-array-bounds.patch<br></blockquote><div>Thanks Wern=
er (and glibc maintainer),</div><div>=C2=A0They&#39;re now committed. Hadn&=
#39;t thought of the length of string sd_session_get_tty returns.</div><div=
><br></div><div>One question though, won&#39;t that mean the destination st=
ring is not nul terminated if the source string is longer than UT_LINESIZE?=
</div><div>It won&#39;t overwrite because it will break out of the for loop=
 now, but wasn&#39;t sure if it would be terminated.</div><div><br></div><d=
iv>=C2=A0- Craig</div><div><br></div><div><br></div></div></div>

--000000000000b0a90a0623516535--