Re: New procps release soon
"Thorsten Kukuk" <[email protected]> ("kukuk") Mon, 30 Sep 2024 09:56:32 +0200
| Newsgroups | gmane.linux.procps.devel |
|---|---|
| Message-ID | <CABMvmLu8C8-oJgGvXaOdAAMp142d0mJw+_RbYo-AjFAW4pFiVw@mail.gmail.com> |
--000000000000c09f5e0623518bac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, due to conference time I didn't had the time to look earlier at the changes. There got a memory leak added to procps_user(), proposed fix is attached. Thorsten Between, it's "SUSE" since 20 years, not "SuSE". On Mon, Sep 30, 2024 at 9:46=E2=80=AFAM Craig Small <dmarc-noreply@freelist= s.org> wrote: > > On Wed, 25 Sept 2024 at 21:14, Dr. Werner Fink <[email protected]> wrote: >> >> >> I've got two patches from our glibc maintainer >> >> procps-ng-4.0.4-idletime-no-tty.patch >> procps-ng-4.0.4-w-array-bounds.patch > > Thanks Werner (and glibc maintainer), > They're now committed. Hadn't thought of the length of string sd_session= _get_tty returns. > > One question though, won't that mean the destination string is not nul te= rminated if the source string is longer than UT_LINESIZE? > It won't overwrite because it will break out of the for loop now, but was= n't sure if it would be terminated. > > - Craig > > --=20 Thorsten Kukuk, Distinguished Engineer, Senior Architect, Future Technologi= es SUSE Software Solutions Germany GmbH, Frankenstra=C3=9Fe 146, 90461 Nuernberg, Germany Managing Director: Ivo Totev, Andrew McDonald, Werner Knoblich (HRB 36809, AG N=C3=BCrnberg) --000000000000c09f5e0623518bac Content-Type: text/x-patch; charset="US-ASCII"; name="uptime.diff" Content-Disposition: attachment; filename="uptime.diff" Content-Transfer-Encoding: base64 Content-ID: <f_m1optczx0> X-Attachment-Id: f_m1optczx0 ZGlmZiAtLWdpdCBhL2xpYnJhcnkvdXB0aW1lLmMgYi9saWJyYXJ5L3VwdGltZS5jCmluZGV4IDVh Y2JkNGJjLi41YzNhM2QzNyAxMDA2NDQKLS0tIGEvbGlicmFyeS91cHRpbWUuYworKysgYi9saWJy YXJ5L3VwdGltZS5jCkBAIC05MSw2ICs5MSw5IEBAIFBST0NQU19FWFBPUlQgaW50IHByb2Nwc191 c2Vycyh2b2lkKQogICAgICAgICAgICAgICAgICAgICBudW11c2VyKys7CiAgICAgICAgICAgICAg ICAgZnJlZShjbGFzcyk7CiAgICAgICAgICAgICB9CisJICAgIGZvciAoaSA9IDA7IGkgPCBzZXNz aW9uczsgaSsrKQorCSAgICAgIGZyZWUoc2Vzc2lvbnNfbGlzdFtpXSk7CisJICAgIGZyZWUoc2Vz c2lvbnNfbGlzdCk7CiAgICAgICAgICAgICByZXR1cm4gbnVtdXNlcjsKICAgICAgICAgfQogICAg IH0K --000000000000c09f5e0623518bac--