Re: [PATCH 4/5] xor/arm64: Use shared NEON intrinsics implementation from 32-bit ARM
Christoph Hellwig <[email protected]>
| Newsgroups | gmane.linux.kernel.cryptoapi,gmane.linux.raid,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Mar 30, 2026 at 11:38:15AM +0200, Ard Biesheuvel wrote: > > This avoid the including of .c files which is always a bit ugly. > > But if there is a strong argument to prefer including of the .c file I > > can live with that as well. > > > > I've respun it without the include. Instead, I've added this to arm/xor-neon.c > > +#ifdef CONFIG_ARM64 > +extern typeof(__xor_neon_2) __xor_eor3_2 __alias(__xor_neon_2); > +#endif > > so that __xor_eor3_2() exists in the arm64 build as an alias. That way, the arm64-only EOR3 implementation can just remain a separate compilation unit. Ok.