Re: [PATCH] ASoC: tas2783-sdw: power the Function up before preparing the port

Robin Everaars <[email protected]>
Newsgroups gmane.linux.kernel,gmane.linux.sound
Message-ID <[email protected]>
Andrey,

thanks. One clarification about my negative v1 result: it was not an
active-playback resume test. The controlled pre-suspend tone had completed
before system suspend. The PipeWire sink was then idle for much longer than
WirePlumber's default five-second node-suspend timeout. After wake I started a
new pw-play process.

I did not trace the ALSA ioctls in that run, so I cannot prove exactly how
PipeWire reactivated the PCM. The test was not designed to call
snd_pcm_resume() on a running stream and should not be used as evidence for
that path.

That makes the missing b627da430357 on v7.1.7 the more relevant difference for
my result, although I have not proved that attribution yet. I agree that the
next useful test is the exact v2 series on broonie/sound for-next rather than
another cycle on v7.1.7.

I will keep the cases separate:

  - an active hw stream recovered only with snd_pcm_resume();
  - an idle PipeWire sink followed by fresh playback after resume;

  - a hw stream left PREPARED across suspend, then started without another
    prepare, to confirm the remaining gap described in the cover letter.

I will mask the resume rebind during each attributable cycle and keep the same
pre/post acoustic measurement.

Please send the register-readout module off-list. I can capture DP1
PrepareCtrl, PrepareStatus, ChannelEn and PDE23 around each path, especially if
one still fails on for-next.

Thanks,
Robin
publickey - [email protected] - 0x8B6BA132.asc (application/pgp-keys, 889 B)
-----BEGIN PGP PUBLIC KEY BLOCK-----
Comment: https://gopenpgp.org
Version: GopenPGP 2.10.0

xjMEah8lZRYJKwYBBAHaRw8BAQdAaRkzve49rBEJMKJH746RXHY+2fT77oxROi5d
8JpL+67NKXJvYmluZXZlcmFhcnNAcG0ubWUgPHJvYmluZXZlcmFhcnNAcG0ubWU+
wsARBBMWCgCDBYJqHyVlAwsJBwkQHcV/a8sGGopFFAAAAAAAHAAgc2FsdEBub3Rh
dGlvbnMub3BlbnBncGpzLm9yZx6V5qS89w7CDYSIsc5NxuPJI1rgoEyY/v8dbP3H
qkoNAxUKCAQWAAIBAhkBApsDAh4BFiEEi2uhMrb2XujFnFjLHcV/a8sGGooAAAZs
AP9zIKWwubClFEs0J6jpQHTKXFTq+99MRkfDKqITbumQzQD/R2OazTp4oCJO2bOD
NFliVAm8yXP6A+586zR2YKt0RAbOOARqHyVlEgorBgEEAZdVAQUBAQdA3p5F7b5O
FsWKrSWEmEHia/oe7no/+Z1W0OPffYrDPy8DAQgHwr4EGBYKAHAFgmofJWUJEB3F
f2vLBhqKRRQAAAAAABwAIHNhbHRAbm90YXRpb25zLm9wZW5wZ3Bqcy5vcmevUdR+
V+3UgvIVjqDLFOWyyGp5h4JXAPfYZsD//RHgvQKbDBYhBItroTK29l7oxZxYyx3F
f2vLBhqKAABoFgEA8e4eSLSaLmv8/e2W1L9/VKAbj2Z7JES6KApi9BZ6nQgBANhZ
FhMFzsyzu2YYtaB8SYtVthJJ6/eIQTT6UdQEIYsF
=YKhM
-----END PGP PUBLIC KEY BLOCK-----
signature.asc (application/pgp-signature, 322 B)
-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wqsEARYIAF0Fgmp+NMYJEB3Ff2vLBhqKNRQAAAAAABwAEHNhbHRAbm90YXRp
b25zLm9wZW5wZ3Bqcy5vcmdrQOBjmGen5IBy8SpvS9HqFiEEi2uhMrb2XujF
nFjLHcV/a8sGGooAAHxHAQDERIPEYn0iypt6F2VhmplgAZQRvXDJgXuHnP+v
eZKSYQD/TE5ly/PHEUFHheuFCVXr0gGAqK9vyoUzDWMscZcNRQU=
=P9DI
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.