Re: [PATCH v2] ASoC: tas2783-sdw: add firmware download status check
Mark Brown <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.alsa.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 13, 2026 at 10:14:50AM +0800, Baojun Xu wrote:
> Currently, the firmware download is unnecessarily triggered on every
> system resume from suspend, causing significant wake-up latency. However,
> this step is redundant if the AMP remains powered on. Furthermore, certain
> memory pages (addresses > 0xc60000) are skipped even after an AMP reset.
> + if (!tas_dev->first_hw_init || file->dest_addr < 0xc60000) {
> + ret = sdw_nwrite_no_pm(tas_dev->sdw_peripheral,
> + file->dest_addr,
> + file->length,
> + file->fw_data);
What happens if the amplifier uses power (eg, over a system suspend)?
Though since nothing clears first_hw_init I guess there might be issues
there anyway...
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmp+QwIACgkQJNaLcl1U h9ANegf+JK0QxQwgfNUpmn4rEGyfPdGNwOIGZnhXTPQ1YQw0Z1HGeeGH/Xf7DHxX 0g8LX84V5NA3QMrDjlBCcJZSaFbBXNDzk1dQAp8ssgnOewMD7NyMp5UY1qs+/NpH RtlfGxbEZdgj//sJhYLocDrKObOkKoXO1R59TM+A+1Ua0KK8exlfeCtBJMyL2uEl PYlNslBO5GcB0yK8WCImKyFhM6Ijinhcds6fTgzbaNlUP6r1CeiYR697sK/HxjZp nx0ACestXtzHlPNUYKNjGmQEN1fqijp5N7nLm1Wf7W3wIYSVY9O1Y0b0ObrPzYTu AmcRVLekfBsYJvXw+Ql6Z1esLHPsnw== =BSuN -----END PGP SIGNATURE-----