Re: [RFC PATCH 0/3] ASoC: Intel: Add Lenovo Yoga Book RT5677 support

On 8/26/2026 3:23 PM, Maurizio Casciano wrote:
> The Lenovo Yoga Book YB1-X91F/L uses a Cherry Trail SSP2 connection to
> an RT5677 codec, with board-specific amplifier, headphone and headset
> detector wiring.  Add the machine driver, the SST machine-table match,
> and the SOF topology filename used by the corresponding external SOF
> topology.
> 
> The companion platform/x86 series supplies the TS3A227E device and codec
> GPIO lookup entries.  The sof-cht-rt5677.tplg topology is maintained in
> the SOF project and must be merged and distributed separately.
> 
> With the matching topology installed, the Yoga Book reaches the SOF
> card-registration and stream setup path.  End-to-end playback and
> capture acceptance is not complete, so this is posted as an RFC.
> 
> Maurizio Casciano (3):
>    ASoC: Intel: Add Lenovo Yoga Book RT5677 machine driver
>    ASoC: Intel: cht: Match the Yoga Book RT5677 machine
>    ASoC: Intel: cht: Add Yoga Book SOF topology filename
Hello,

Unless I'm missing something, this looks like a resend of a patchset 
from earlier this year [1]. Previous owner of the subject, Yauhen 
Kharuzhy, is not even CC'ed here. I do not see any of the review points 
addressed here, moreover, I see a regression when compared to v3 from June.

Hiding behind RFC (not v4) is a weird move when viewed in context of 
CHT. The configuration is mature, CHT is over 12 years old. With basic 
playback/capture not enabled, does the review make sense?


[1]: 
https://lore.kernel.org/linux-sound/[email protected]/

Kind regards,
Czarek