Re: [PATCH] ASoC: amd: acp-config: add quirk for more ASUS FA401EA variants
Mark Brown <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Aug 26, 2026 at 05:42:09PM +0800, Shengyu Qu wrote:
> Existing quirks doesn't cover all known exising FA401EA devices, so add
> more quirk items to cover them.
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "FA401EA"),
> + },
> + },
> {
> .matches = {
> DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
> DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A14 FA401EA"),
> },
> },
> + {
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401EA"),
> + },
> + },
Do we need all these entries, DMI matches use substr() so I'd expect the
first entry to match on all the machines that the other two matches,
unless I'm misunderstanding somehow?
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqO9xIACgkQJNaLcl1U h9BhyAgAgGr3ZbDLxcansrn1RsdEb9DiI6bowv+eCw+yE68nmfF6F8ztjxnsJo1y TcTNYmjwbZD/1AMACDD6G0fZQPXQIYH4mK2DaYDm1H2t2jBqc6gTNuIkJp7u0m+P aovEM6fGipHwXVhr/Eg9OMcKyh5cYFU4+7ipagb6tIrQuwlCY083mFWLkkyDPWNQ 1XrlxByJpZ2yhU83hHNw4BD66cSSNVa3sSFqHZoT2IwszKBvFwhQdoq6jU51HjGT 9G1ynW9evn8AC7ZZh5rCJ2SZt6oDzjzU2wN/wC4Rt9XqWp3b1fun8g7gWyoCeqKa Ps7tKSxDbN6liSx8l61tlx/hkLSbmA== =g/jI -----END PGP SIGNATURE-----