Re: [PATCH] ALSA: control: Don't add invalid kcontrols to LED layer
Jaroslav Kysela <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/27/26 13:39, Takashi Iwai wrote: > The kcontrol LED state layer tries to track the all associated > kcontrol elements with naive assumptions that they are readable. > But one can create a write-only element that has no get callback (even > a user element can do it), and this may lead to a NULL dereference at > the call chain of snd_ctl_led_notify(), as found by syzkaller. > > For avoiding the Oops, add a sanity check of the kcontrol's info and > get callbacks, and just skip the invalid kcontrols before assigning > the kctl to the LED layer. > > Reported-by: [email protected] > Closes: https://lore.kernel.org/[email protected] > Fixes: 22d8de62f11b ("ALSA: control - add generic LED trigger module as the new control layer") > Signed-off-by: Takashi Iwai <[email protected]> Reviewed-by: Jaroslav Kysela <[email protected]> -- Jaroslav Kysela <[email protected]> Linux Sound Maintainer; ALSA Project; Red Hat