Re: [PATCH v4 1/2] ASoC: Intel: Add Cherry Trail RT5677 machine driver
Mark Brown <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 27, 2026 at 09:25:16AM +0200, Maurizio Casciano wrote: > Link: https://github.com/jekhor/yogabook-linux-kernel/commit/4e41d0ff72c1d1fd8d5c59dda247e4ca8a1da999 > > Link: https://lore.kernel.org/linux-sound/[email protected]/ > > Signed-off-by: Maurizio Casciano <[email protected]> > > Assisted-by: Codex:gpt-5.6-sol sparse This isn't how trailers should be formatted, please look at other commits for examples. > +static int cht_rt5677_codec_fixup(struct snd_soc_pcm_runtime *rtd, > + struct snd_pcm_hw_params *params) > +{ > + /* > + * Configure SSP2 for the 24-bit format expected by the codec. The SST > + * ssp2-port front end still advertises S16_LE and converts the stream. > + */ > + params_set_format(params, SNDRV_PCM_FORMAT_S24_LE); params_set_format() is addative, it won't clear any existing format that was set which is not what you're looking for here.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmqQNgAACgkQJNaLcl1U h9AQswgAgUPt0bIXdFJSZxVT7TpT208MNCIDuuCtxIVhf5YZtT+z2frAM/cjl89l kc3TAfzKH/wT20JTj8YzuPkZXUHRjsog7oltSyIIMklJZ3ZMASLDLoUr1/a54hTS ccEbDb6Ot2RumCNbYk3XKwZNTw0cmE+qj6YxekgmADzR68Ns3LXx4Z/7q+kL+iQR IPAJ9qV4hT8Bw4dDEGEYxGCleUzywMDNYlf9vnnrNcc5QXaKa9ll+Jb/LrTjikJT tLinGIueSE2SsofLk4uNFj84EA3aafGNWRVhHWG0ivUGmnASFsOI3pH2NWwHhd+7 XocLVvWC0Rr9l07pNWmPqS9qxlr0Mw== =4+xY -----END PGP SIGNATURE-----