Re: Subject: Proposed changes to jetpipe

On 10-12-12 04:56 PM, Jam wrote:
> On Monday 13 December 2010 06:15:33 ltsp-developer-
> [email protected] wrote:
>> I'm attaching a patch that removes the LTSP written "fork twice to
>> daemonize" code handed down to us by His Holiness St. Stevens, and
>> substitutes in the standard python daemon object.  It also adds a "-d"
>> or "--debug" switch, that stops the process from backgrounding, so you
>> can see stderr and stdout messages, useful for, well, debugging.
>>
>> The only minor problem is that it now puts another dependency on the
>> "python-daemon" package (in debian based distros, not sure what it is
>> for our RPM distro maintainers).
>>
>> What do you all think?  I think it clarifies and shortens the code
>> tremendously.  And the less code we have to maintain...
>>
>> Let me know your thoughts.  If the general consensus is to go for it,
>> I'll commit it upstream.
>
> Scott the fork-twice is the right-way (tm) to do it.

Correct. But now the daemon() call using the python library handles that.  I 
perhaps wasn't clear enough:

The python deamon() library does the standard Stevens 
fork-twice-create-processgroup-close-filehandles goodness that a proper daemon 
should do. By using the pre-defined library, WE can pull that stuff out of our 
code, and just use what's already there, making our code smaller.  That was the 
purpose of the change; why re-invent the wheel.

> Change for other reasons, but not to get rid of this behaviour.

Behaviour, at least in my testing, is exactly the same.  I agree wholeheartedly 
with you.

> (Technical stuff about controlling terminal etc, and BTW  what kde is NOT
> doing so eg launch k3b, kmail etc in a terminal and the app daemonises but
> leaves heaps of ongoing mouse droppings in the terminal)
> James
>
> ------------------------------------------------------------------------------
> Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL,
> new data types, scalar functions, improved concurrency, built-in packages,
> OCI, SQL*Plus, data movement tools, best practices and more.
> http://p.sf.net/sfu/oracle-sfdev2dev
> _____________________________________________________________________
> Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
>        https://lists.sourceforge.net/lists/listinfo/ltsp-developer
> For additional LTSP help,   try #ltsp channel on irc.freenode.net


-- 
Scott L. Balneaves | I don't have any solution,
Systems Department | but I certainly admire the problem.
Legal Aid Manitoba |     -- Ashleigh Brilliant

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net