Re: LDM build warnings

Patch fixing this is attached.

Cheers

-J

On Sun, Mar 20, 2011 at 1:32 PM, Jigish Gohil <[email protected]> wrote:
> Hi
>
> openSUSE Build Service checks packages being built and gives out
> warnings/informations to fix issues, here is the one for the new LDM
> package, please see what is required to get rid of these messages.
>
> Kind regards
>
> -J
>
> I: Program is using implicit definitions of functions getting
>   pointers or implemented by macros. These functions need to use their
>   correct prototypes to allow correct argument passing on e.g. x86_64 .
>     - Implicit memory/string functions need #include <string.h>.
>     - Implicit *printf functions need #include <stdio.h>.
>     - Implicit *printf functions need #include <stdio.h>.
>     - Implicit *read* functions need #include <unistd.h>.
>     - Implicit *recv* functions need #include <sys/socket.h>.
> W: ldm2 implicit-pointer-decl ../src/ldminfo.c:168
> W: ldm2 implicit-pointer-decl ldmgreetercomm.c:87
> W: ldm2 implicit-pointer-decl ldminfo.c:168
> W: ldm2 implicit-pointer-decl ssh.c:381, 450
>
> I: Program is using uninitialized variables.
>   Note the difference between "is used" and "may be used"
> W: ldm2 uninitialized-variable greeter.c:282, 704
>
> I: Program is using implicit definitions of special functions.
>   these functions need to use their correct prototypes to allow
>   the lightweight buffer overflow checking to work.
>     - Implicit memory/string functions need #include <string.h>.
>     - Implicit *printf functions need #include <stdio.h>.
>     - Implicit *printf functions need #include <stdio.h>.
>     - Implicit *read* functions need #include <unistd.h>.
>     - Implicit *recv* functions need #include <sys/socket.h>.
> E: ldm2 implicit-fortify-decl ../src/ldminfo.c:161
> E: ldm2 implicit-fortify-decl ldminfo.c:161
> E: ldm2 implicit-fortify-decl prefs.c:27
> E: ldm2 implicit-fortify-decl ssh.c:153, 307
>



-- 
CyberOrg Info
Linux Powered Training and Solutions Provider
7 FF Unaddeep, Tower A, Susen Tarsali Road, Vadodara, India 390 010
M +91 9898092956
Web. http://www.cyberorg.info

------------------------------------------------------------------------------
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey

_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net

diff -ur a/gtkgreet/prefs.c b/gtkgreet/prefs.c
--- a/gtkgreet/prefs.c	2011-07-27 17:20:06.000000000 +0530
+++ b/gtkgreet/prefs.c	2011-08-01 18:58:58.000000000 +0530
@@ -20,6 +20,10 @@
  */
 #include <glib.h>
 #include "prefs.h"
+#include <string.h>
+#include <stdio.h>
+#include <unistd.h>
+#include <sys/socket.h>
 
 static GTree* greeter_prefs = NULL;
 
diff -ur a/src/ldminfo.c b/src/ldminfo.c
--- a/src/ldminfo.c	2011-07-27 17:20:06.000000000 +0530
+++ b/src/ldminfo.c	2011-08-01 18:36:35.000000000 +0530
@@ -29,6 +29,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <unistd.h>
+#include <sys/socket.h>
 #include <sys/ioctl.h>
 
 #include "ldminfo.h"
diff -ur a/src/plugins/ssh/ssh.c b/src/plugins/ssh/ssh.c
--- a/src/plugins/ssh/ssh.c	2011-07-27 17:20:06.000000000 +0530
+++ b/src/plugins/ssh/ssh.c	2011-08-01 18:39:52.000000000 +0530
@@ -11,6 +11,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <unistd.h>
+#include <sys/socket.h>
 #include <sys/ioctl.h>
 #include <sys/stat.h>
 #include <utmp.h>