Re: Enable numlock in ldm greeter

hi,
Am Mittwoch, den 09.07.2008, 12:24 +0200 schrieb Leo Eraly:
> Since I'm not an experienced (C) programmer It's possible that it
> still contains some undocumented features/bugs ;-)
> 
> 
> Feedback is appreciated.
looks very good so far ... but to restate what i said on IRC:

* please use four spaces instead of tabs in ltsp code ...
* if setxkbmap and numlockx use the same g_spawn_sync calls we should
unify that in a function both can use and not duplicate the code.
* if you add a var to lts.conf, please document it in lts-parameters.txt
in the server/doc dir of the ltsp-trunk branch so we dont lose track of
available vars...

apart from that the patch looks good to me

ciao
	oli

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08

_____________________________________________________________________
Ltsp-developer mailing list.   To un-subscribe, or change prefs, goto:
      https://lists.sourceforge.net/lists/listinfo/ltsp-developer
For additional LTSP help,   try #ltsp channel on irc.freenode.net

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIdJfQSsOT+6LQaTYRAsBJAKDsvRLUzGdqUkoD8N7iY90/hZn9ngCfZIHq
FkkZQECQqtL/bKFgwAL1nfA=
=Xqsl
-----END PGP SIGNATURE-----