Re: Enable numlock in ldm greeter
"Leo Eraly" <[email protected]>
| Newsgroups | gmane.linux.terminal-server.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jul 9, 2008 at 12:49 PM, Oliver Grawert <ogra-GeWIH/[email protected]> wrote: > hi, > Am Mittwoch, den 09.07.2008, 12:24 +0200 schrieb Leo Eraly: > > Since I'm not an experienced (C) programmer It's possible that it > > still contains some undocumented features/bugs ;-) > > > > > > Feedback is appreciated. > looks very good so far ... but to restate what i said on IRC: > > * please use four spaces instead of tabs in ltsp code ... Fixed in the new attached patch > > * if setxkbmap and numlockx use the same g_spawn_sync calls we should > unify that in a function both can use and not duplicate the code. Agreed but since I'm not the C guru I'll leave this to others. > > * if you add a var to lts.conf, please document it in lts-parameters.txt > in the server/doc dir of the ltsp-trunk branch so we dont lose track of > available vars... See the 2nd patch (for lts-parameters.txt) > > > apart from that the patch looks good to me Thx for the feedback Leo ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _____________________________________________________________________ Ltsp-developer mailing list. To un-subscribe, or change prefs, goto: https://lists.sourceforge.net/lists/listinfo/ltsp-developer For additional LTSP help, try #ltsp channel on irc.freenode.net
greeter.c.patch2
(application/octet-stream, 882 B) - not displayed
lts-parameters.patch
(text/x-patch, 851 B)
=== modified file 'server/doc/lts-parameters.txt' --- server/doc/lts-parameters.txt 2008-06-25 08:47:54 +0000 +++ server/doc/lts-parameters.txt 2008-07-09 12:37:22 +0000 @@ -157,4 +157,6 @@ XDM_SERVER XDMCP server IP ltsp server for use with SCREEN_nn=xdmcp --------------------------------------------------------------------------------------------- SSH_OVERRIDE_PORT Portnumber unset for use with a dedicated ssh port ---------------------------------------------------------------------------------------------- +------------------------------------------------------------------------------------------- +NUM_LOCK Y,N unset enable numlock in LDM (at startup) +-------------------------------------------------------------------------------------------