Re: [PATCH] lpd: write debug messages to stdout with compile-time or run-time flags
Vasant Hegde <[email protected]> Wed, 9 Nov 2016 16:31:25 +0530
| Newsgroups | gmane.linux.tools.diag.devel |
|---|---|
| Message-ID | <[email protected]> |
On 11/08/2016 10:57 PM, Mauricio Faria de Oliveira wrote:
> If LPD_DEBUG is set at compile time (e.g., make CFLAGS=3D'-DLPD_DEBUG'),
> then always write the messages at runtime.
>
> If it's not (default), check if the LPD_DEBUG environment variable
> is set at runtime (e.g., export LPD_DEBUG=3D1), and only write if it is.
So we have new build warning and I don't like that. Can you please fix belo=
w =
warning and resend entire patchset ?
CC lpd/files.o
files.c: In function =91_dbg=92:
files.c:180:18: warning: format not a string literal and no format argument=
s =
[-Wformat-security]
fprintf(stdout, buf);
^
-Vasant
---------------------------------------------------------------------------=
---
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi