Re: [PATCH 1/3] lpd: Add support for Marvell HDD LEDs on S822LC for HPC

On 11/09/2016 08:43 AM, Vasant Hegde wrote:
>>>> +void
>>>> +get_mv_indices(int indicator, struct loc_code **loc_list)
>>>> +{
>>>> +    struct    dev_vpd *vpd_list, *vpd_curr;
>>>> +
>>>> +    /* support for identification LEDs only */
>>>> +    if (indicator != LED_TYPE_IDENT)
>>>
>>> I assume it doesn't have fault indicator.
>>
>> That's correct.
>>
>> Although the purpose of these patches is to turn on/off what we call
>> 'fault LEDs' for the disks in marvell sata controller, those are not
>> really fault LEDs -- like those that light on automatically once a
>> fault occurs, and can be turned off with usysattn/fault.
>>
>> For this controller, what we have is the user manually turns the LEDs on
>> (and off) with usysident, in order to unplug a disk, for example.
>
> Sorry. I'm not sure I understood it correctly.
>
> If I understood correctly we have one physical LED .. which is used for
> identifying the device. and it doesn't have fault LED concept. Is that
> right?

iirc, 2 LEDs per disk; 1 for link/activity and 1 for identification;
this patch allows the user to control the latter manually.

yes, no attention/fault LED in the sense of a LED that is automatically
turned on by the adapter/controller firmware once it detects a problem
(and which the user could turn off with usysattn/usysfault).




-- 
Mauricio Faria de Oliveira
IBM Linux Technology Center


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi