Re: PATCH: usb: descriptor structures have to be packed

Pete Zaitcev <[email protected]> writes:

> On Wed, 7 Feb 2007 14:39:28 +0100, Oliver Neukum <[email protected]> wrote:
>> Am Mittwoch, 7. Februar 2007 14:31 schrieb Sergei Organov:
>
>> >   static inline unsigned usb_get_uint16(__u8 const *p)
>> >   {
>> >     return p[0] | (p[1] << 8);
>> >   }
>> 
>> It makes little sense to reinvent le16_to_cpu()
>
> It would not, if le16_to_cpu took a pointer to u8. But as it is,
> functions are quite different.

In fact if there were macro/function similar to get_unaligned(), but
converting from little-/big-endian to native, say, get_unaligned_le(),
I'd use it: 

   static inline unsigned usb_get_uint16(__u8 const *p)
   {
     return get_unaligned_le((__uint16 const*)p);
   }

Unfortunately there is no such macro, or did I miss it?

-- Sergei.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel