Bug in usb_match_one_id()?

Greg:

When you refactored the USB device-matching code, you may have introduced 
a bug.  Does it seem reasonable that an entry might contain both 
device-specific and interface-specific criteria to match?  In which case 
both sets of matches would have to succeed, not just one.

So is the patch below needed?  If yes, I'll send it with a proper patch 
comment and S-O-B.

Alan Stern


Index: usb-2.6/drivers/usb/core/driver.c
===================================================================
--- usb-2.6.orig/drivers/usb/core/driver.c
+++ usb-2.6/drivers/usb/core/driver.c
@@ -415,8 +415,8 @@ int usb_match_one_id(struct usb_interfac
 	intf = interface->cur_altsetting;
 	dev = interface_to_usbdev(interface);
 
-	if (usb_match_device(dev, id))
-		return 1;
+	if (!usb_match_device(dev, id))
+		return 0;
 
 	/* The interface class, subclass, and protocol should never be
 	 * checked for a match if the device class is Vendor Specific,


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel