Re: [PATCH] Davicom DM9601 usbnet driver
Peter Korsgaard <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
>>>>> "David" == David Brownell <[email protected]> writes: Hi, David> Looks nice to me! Thanks; I always like to see new drivers using David> that framework. Great! David> My only comment is that the rx_fixup should probably insist David> that the packets meet Ethernet standards for length; this code David> looks like it'll accept packets smaller than ETH_ZLEN. It's afaik not physically possible to send shorter packets than ETH_ZLEN over the wire, so that shouldn't ever happend (unless there's a bug in the controller). But I can change the if (skb->len < 7) check to do < (7 + ETH_ZLEN) if you like. Or did you rather mean to do a skb_padto(skb, ETH_ZLEN) in tx_fixup? A quick grep shows that no usb drivers do that (perhaps usbnet.c should?) David> Other than that: David> Signed-off-by: David Brownell <[email protected]> Thanks! -- Bye, Peter Korsgaard ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel