Re: [linux-usb-devel] [PATCH] USB: add zr364xx V4L2 driver

Em Dom, 2007-02-18 às 19:57 +0100, Antoine Jacquet escreveu:
> This patch adds a V4L2 driver giving support for USB webcams based on the 
> zr364xx chipsets.
> 
> Signed-off-by: Antoine Jacquet <[email protected]>
> +static struct usb_device_id device_table[] = {
> +	{USB_DEVICE(0x08ca, 0x0109), .driver_info = 0 },

Ok, this works, although it is a little hardcore... it would be better
to use, instead, an enum with the three methods, using an alias that
have some sense for each mode.

> +static int zr364xx_vidioc_querycap(struct file *file, void *priv,
> +				   struct v4l2_capability *cap)
> +{
> +	DBG("VIDIOC_QUERYCAP");

<SNIP/>

When using video_ioctl2, you don't need to have DBG. zr364xx_template
will have a .debug var. if this is equal to 1, it will just print the
ioctl. If equal to 3, it will print the ioctl and its arguments.

Since those stuff is just some cleanup, I'll apply your patch at the
tree, asking Linus to pull it also for 2.6.21.
 
Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list