Re: [PATCH] Davicom DM9601 usbnet driver

>  David> My only comment is that the rx_fixup should probably insist
>  David> that the packets meet Ethernet standards for length; this code
>  David> looks like it'll accept packets smaller than ETH_ZLEN.
>
> It's afaik not physically possible to send shorter packets than
> ETH_ZLEN over the wire, so that shouldn't ever happend (unless there's
> a bug in the controller). But I can change the
> if (skb->len < 7) check to do < (7 + ETH_ZLEN) if you like.

Yes, I think that'd be appropriate.  Either check for the real
limit, or don't check at all ... you're checking for something
significantly less than the real limit.

- Dave

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel