Re: [patch] usb video class support

Paulo Marques <[email protected]>
Newsgroups gmane.linux.usb.devel
Organization Grupo PIE
Message-ID <[email protected]>
Ragner Magalhaes wrote:
> [...]
> +
> +#ifndef __LINUX_USB_VIDEO_H
> +#define __LINUX_USB_VIDEO_H
> +

>[...]

> +#define USB_VC_HEADER_SIZE(n)		(12+(n))
> +
> +/* As above, but more useful for defining your own descriptors: */
> +#define DECLARE_USB_VC_HEADER_DESCRIPTOR(n)			\
> +struct usb_vc_header_descriptor_##n {				\
> +	__u8  bLength;						\
> +	__u8  bDescriptorType;					\
> +	__u8  bDescriptorSubtype;				\
> +	__le16 bcdUVC;						\
> +	__le16 wTotalLength;					\
> +	__le32 dwClockFrequency;				\
> +	__u8  bInCollection;					\
> +	__u8  baInterfaceNr[n];					\
> +} __attribute__ ((packed))
> +
> +#endif
    ^^^^^^

I just noticed this: why is everything below this point declared outside 
"#ifndef __LINUX_USB_VIDEO_H" ?

That will produce double definitions if "linux/usb/video.h" is included 
more than once, no?

-- 
Paulo Marques - www.grupopie.com

"Prediction is hard. Especially of the future."
Niels Bohr

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.